SettingXML not working as of 0.991b2425

[Voltstorm]

Code: Select all

function main()
{
	declare sSettingFile string script "/Scripts/Upop_Settings.xml"
	Echo "${sSettingFile}"
	declare sName string script ${SettingXML[${sSettingFile}].Set[Other].GetString[Name,"NONAME"]}
	Echo "${sName}"
}

XML in /scripts folder:

Code: Select all

`<?xml version='1.0'?>
<InnerSpaceSettings NextID="2">
	<Set ID="1" Name="Other">
		<Setting Name="Name">Ertkrek</Setting>
	</Set>
</InnerSpaceSettings>

There are also unexplained CTD when running the same iss more than once. Does not always happen. The above code is placed in /scripts/main.iss and it crashes when "run main" is executed in console more than once.

[Lax]

You use a scripts folder in the root directory of your hard drive? e.g. C:\Scripts\ ? If not, then I suggest not having that leading / on the filename... Oddly enough, that gets past the absolute path detection in 2425, BUT WILL NOT WORK IN THE NEXT BUILD, just as it should not.

My test with build 2425 (please just use the build number, dont include 0.991b, that's just confusing ) :

Code: Select all

function main()
{
   declare sSettingFile string script "Scripts/Upop_Settings.xml"
   Echo "${sSettingFile}"
   declare sName string script ${SettingXML[${sSettingFile}].Set[Other].GetString[Name,"NONAME"]}
   Echo "${sName}"
} 

ran fine first time, so I set the setting to Jimbob, saved the file, and ran it some more. ran it about 42 times. no crashes, nothing out of the ordinary... exact output I would expect.

Code: Select all

Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob
Scripts/Upop_Settings.xml
Jimbob

ad infinitum

The only other problem I see is the ` before your <?xml ... but I assume that was a copy and paste error and does not really appear in the xml. Or does it?

Testing with the ` in the XML, it a) Fails to load, and b) Crashes on the second run.

Fix the XML, and dont use absolute paths when you mean to use relative paths!

[Voltstorm]

This structure has worked fine for months ...

My install is c:\InnerSpace
the XML file is in c:\InnerSpace\Scripts
the script file is in c:\InnerSpace\Scripts

and even if I remove the leading / it still returns NULL and CTD on second attempt.

[Lax]

I'm sure it has worked for months, but the point is that it shouldnt work because of how file systems work. If you use a leading slash, you are implying an absolute path, and it should only be looking in the root directory.

and even if I remove the leading / it still returns NULL and CTD on second attempt.

That's because you didnt read second half of my post

[Voltstorm]

even if I hardwire the structure it returns NULL and CTD on second call.

Code: Select all

function main()
{
	declare sSettingFile string script "C:/InnerSpace/Scripts/Upop_Settings.xml"
	Echo "${sSettingFile}"
	declare sName string script ${SettingXML[${sSettingFile}].Set[Other].GetString[Name,"NONAME"]}
	Echo "${sName}"
}

[Lax]

Please stop doing anything until you fix the XML as explained in the second half of my post.

[Voltstorm]

Clearly there is an issue someplace ...

Code: Select all

function main()
{
	declare sSettingFile string script "C:\\InnerSpace\\Scripts\\Upop_Settings.xml"
	Echo "${sSettingFile}"
	declare sName string script ${SettingXML[${sSettingFile}].Set[Other].GetString[Name,"NONAME"]}
	Echo "${sName}"
}

Should result in ...

Code: Select all

C:\InnerSpace\Scripts\Upop_Settings.xml
<name>

But results in ...

Code: Select all

C:InnerSpaceScriptsUpop_Settings.xml
NONAME

[Voltstorm]

hose me down and call me an ass, PLEASE!

[Lax]

It shouldnt result in C:\Innerspace\etc because of escaping, but if you change it to ${sSettingFile.Escape} it outputs correctly

Anyhow, the issue you experienced should not CRASH but should fail to load (with an error), and I am fixing that. But at least I got you to stop crashing finally